refactor(elasticsearch-exporter): output raw message on JSON error #10971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that the raw message is printed as part of the stacktrace when the server returns a successful, but invalid message, so we can more easily diagnose what is happening.
Zelldon
approved these changes
Nov 10, 2022
...ters/elasticsearch-exporter/src/main/java/io/camunda/zeebe/exporter/ElasticsearchClient.java
Outdated
Show resolved
Hide resolved
|
Your comment made me realize I should make it more explicit why we're doing this. Someone who's unaware of this error reporting behavior but aware that Jackson can deserialize an |
|
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Nov 11, 2022
10971: refactor(elasticsearch-exporter): output raw message on JSON error r=npepinpe a=npepinpe ## Description Ensures that the raw message is printed as part of the stacktrace when the server returns a successful, but invalid message, so we can more easily diagnose what is happening. ## Related issues closes #10970 Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
|
Successfully created backport PR #10981 for |
remcowesterhoud
added
the
version:8.1.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures that the raw message is printed as part of the stacktrace when the server returns a successful, but invalid message, so we can more easily diagnose what is happening.
Related issues
closes #10970
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.