Add warning for even replication factor #11831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broker/src/main/java/io/camunda/zeebe/broker/system/SystemContext.java
Outdated
Show resolved
Hide resolved
Test Results 995 files ± 0 995 suites ±0 1h 48m 20s ⏱️ + 4m 13s Results for commit 4ef0238. ± Comparison against base commit 680e472. This pull request removes 550 and adds 475 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
@oleschoenburg can you take a look again. |
oleschoenburg
approved these changes
Feb 27, 2023
Zelldon
force-pushed
the
zell-warning-replication-factor
branch
from
d15ba71
to
4ef0238
Compare
|
bors r+ |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Feb 28, 2023
11831: Add warning for even replication factor r=Zelldon a=Zelldon ## Description Ass discussed in slack https://camunda.slack.com/archives/C037RS2JHB8/p1677221646815649 I added a warning for even replication factor, as this is also a question or misconfiguration I often have seen in the forum. I would like to back port this to our other supported versions. 11839: deps(maven): bump aws-java-sdk-core from 1.12.415 to 1.12.416 r=oleschoenburg a=dependabot[bot] Bumps [aws-java-sdk-core](https://github.com/aws/aws-sdk-java) from 1.12.415 to 1.12.416. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md">aws-java-sdk-core's changelog</a>.</em></p> <blockquote> <h1><strong>1.12.416</strong> <strong>2023-02-27</strong></h1> <h2><strong>AWS Elemental MediaConvert</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>The AWS Elemental MediaConvert SDK has added support for HDR10 to SDR tone mapping, and animated GIF video input sources.</li> </ul> </li> </ul> <h2><strong>AWS Lambda</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>This release adds the ability to create ESMs with Document DB change streams as event source. For more information see <a href="https://docs.aws.amazon.com/lambda/latest/dg/with-documentdb.html">https://docs.aws.amazon.com/lambda/latest/dg/with-documentdb.html</a>.</li> </ul> </li> </ul> <h2><strong>Amazon CloudWatch Internet Monitor</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>CloudWatch Internet Monitor is a a new service within CloudWatch that will help application developers and network engineers continuously monitor internet performance metrics such as availability and performance between their AWS-hosted applications and end-users of these applications</li> </ul> </li> </ul> <h2><strong>Amazon DevOps Guru</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>This release adds the description field on ListAnomaliesForInsight and DescribeAnomaly API responses for proactive anomalies.</li> </ul> </li> </ul> <h2><strong>Amazon Timestream Write</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>This release adds the ability to ingest batched historical data or migrate data in bulk from S3 into Timestream using CSV files.</li> </ul> </li> </ul> <h2><strong>Elastic Disaster Recovery Service</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>New fields were added to reflect availability zone data in source server and recovery instance description commands responses, as well as source server launch status.</li> </ul> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-sdk-java/commit/8d9555dca5c43682cba7c1f67981bd7a61fd0f17"><code>8d9555d</code></a> AWS SDK for Java 1.12.416</li> <li><a href="https://github.com/aws/aws-sdk-java/commit/37b4fb884e3ed111e3211c5c8a4d8a529146a6d4"><code>37b4fb8</code></a> Update GitHub version number to 1.12.416-SNAPSHOT</li> <li>See full diff in <a href="https://github.com/aws/aws-sdk-java/compare/1.12.415...1.12.416">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: Christopher Zell <zelldon91@googlemail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Build failed (retrying...): |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Feb 28, 2023
11831: Add warning for even replication factor r=Zelldon a=Zelldon ## Description Ass discussed in slack https://camunda.slack.com/archives/C037RS2JHB8/p1677221646815649 I added a warning for even replication factor, as this is also a question or misconfiguration I often have seen in the forum. I would like to back port this to our other supported versions. Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-11831-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-11831-to-stable/8.0
git checkout -b backport-11831-to-stable/8.0
ancref=$(git merge-base 680e472b7d2ae0f578f2749ef483e1f042fc6fcb 4ef0238273a2fa76273869a6e88dbd8a1b9ceb54)
git cherry-pick -x $ancref..4ef0238273a2fa76273869a6e88dbd8a1b9ceb54 |
|
Successfully created backport PR for |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Feb 28, 2023
11854: [Backport 8.0]: Add warning for even replication factor r=oleschoenburg a=Zelldon ## Description Backports #11831 <!-- Please explain the changes you made here. --> Had to resolve some smaller merge conflicts, in the system context. Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
megglos
added
the
version:8.1.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ass discussed in slack https://camunda.slack.com/archives/C037RS2JHB8/p1677221646815649 I added a warning for even replication factor, as this is also a question or misconfiguration I often have seen in the forum.
I would like to back port this to our other supported versions.