Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Assign task user task action #16667

Merged
merged 3 commits into from Mar 1, 2024
Merged

Support Assign task user task action #16667

merged 3 commits into from Mar 1, 2024

Conversation

tmetzke
Copy link
Member

@tmetzke tmetzke commented Mar 1, 2024

Description

  • Add user task assignment support to the Zeebe Java client via ZeebeClient#newUserTaskAssignCommand.
  • The command takes a user task key and assignee and can optionally take an action.
  • Plus, users can allow overriding an assignee in the engine.

Related issues

closes #16663

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

@tmetzke tmetzke self-assigned this Mar 1, 2024
@tmetzke tmetzke linked an issue Mar 1, 2024 that may be closed by this pull request
Support Assign task user task action #16663
Closed
@tmetzke tmetzke force-pushed the 16663-client-user-task-assign branch 3 times, most recently from 639ad58 to cfe29c2 Compare March 1, 2024 12:59
@tmetzke tmetzke changed the title 16663 client user task assign Support Assign task user task action Mar 1, 2024
koevskinikola
koevskinikola approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@koevskinikola koevskinikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

It would be good to introduce some QA tests for this command. Let's create a follow-up issue for that.

zeebe/clients/java/src/main/java/io/camunda/zeebe/client/ZeebeClient.java Outdated Show resolved Hide resolved
ana-vinogradova-camunda
ana-vinogradova-camunda approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@ana-vinogradova-camunda ana-vinogradova-camunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tmetzke and others added 3 commits March 1, 2024 16:34
@tmetzke @koevskinikola
feat: add user task assignment command objects
9486d57 
Creates the API for issueing user task assignment commands in the Java client.
User task assignment can take a custom "action" and an "assignee". Plus, the command
can allow overriding the assignee in the engine.
@tmetzke @koevskinikola
feat: add user task assignment command to client
a73e4f3 
Adds a user task assignment command method to the Java client. Users can create assignment
requests in the client with a user task key, action, and assignee using "newUserTaskAssignCommand".
Plus, users can allow overriding the assignee in the engine.
@tmetzke @koevskinikola
refactor: fix type in Zeebe client interface docs
01d8233 
Co-authored-by: Nikola Koevski <nikola.koevski@camunda.com>
Base automatically changed from 16447-client-user-task-complete to main March 1, 2024 16:13
@ana-vinogradova-camunda ana-vinogradova-camunda added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit ced94e0 Mar 1, 2024
30 checks passed
@ana-vinogradova-camunda ana-vinogradova-camunda deleted the 16663-client-user-task-assign branch March 1, 2024 16:26
@megglos megglos added the version:8.5.0-alpha2 Label that represents issues released on verions 8.5.0-alpha2 label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koevskinikola koevskinikola koevskinikola approved these changes

@ana-vinogradova-camunda ana-vinogradova-camunda ana-vinogradova-camunda approved these changes

Assignees

@tmetzke tmetzke

Labels
version:8.5.0-alpha2 Label that represents issues released on verions 8.5.0-alpha2 version:8.5.0 Label that represents issues released on verions 8.5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Assign task user task action
5 participants
@tmetzke @koevskinikola @ana-vinogradova-camunda @megglos @oleschoenburg