Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check to make sure index exists before adding a policy #16984

Merged
merged 3 commits into from Mar 25, 2024

Conversation

robert-sorkin
Copy link
Contributor

Description

•Recreating PR due to monorepo changes. Original PR: https://github.com/camunda/operate/pull/6641

•Added check to see if index exists
•Added some unit tests to ElasticsearchArchiveRepository and OpensearchArchiveRepository

Related issues

closes https://github.com/camunda/operate/issues/5921

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

@robert-sorkin robert-sorkin added the component/operate Related to the Operate component/team label Mar 19, 2024
@robert-sorkin robert-sorkin requested a review from a team March 19, 2024 20:52
Copy link
Contributor

github-actions bot commented Mar 19, 2024

Test Results

974 tests   938 ✅  2h 30m 32s ⏱️
170 suites   36 💤
170 files      0 ❌

Results for commit 59be482.

♻️ This comment has been updated with latest results.

@robert-sorkin robert-sorkin added this pull request to the merge queue Mar 25, 2024
Merged via the queue into main with commit 6bf640f Mar 25, 2024
14 checks passed
@robert-sorkin robert-sorkin deleted the be-5921-no-ilm-policy branch March 25, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/operate Related to the Operate component/team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants