Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients/java): parse USE_PLAINTEXT_CONNECTION as boolean #4459

Merged
merged 1 commit into from
May 11, 2020

Conversation

pihme
Copy link
Contributor

@pihme pihme commented May 6, 2020

Description

Changes behavior of USE_PLAINTEXT_CONNECTION flag; If it is explicitly set to false, it won't be applied.

Related issues

closes #4245

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

@pihme pihme requested a review from saig0 May 6, 2020 06:59
@saig0
Copy link
Member

saig0 commented May 11, 2020

bors r+

zeebe-bors bot added a commit that referenced this pull request May 11, 2020
4459: fix(clients/java): parse USE_PLAINTEXT_CONNECTION as boolean r=saig0 a=pihme

## Description

Changes behavior of `USE_PLAINTEXT_CONNECTION` flag; If it is explicitly set to `false`, it won't be applied.

## Related issues

closes #4245

#

Co-authored-by: pihme <pihme@users.noreply.github.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented May 11, 2020

Build failed

@saig0
Copy link
Member

saig0 commented May 11, 2020

Failed because of unstable test: io.zeebe.broker.it.clustering.SingleBrokerDataDeletionTest.shouldNotCompactNotExportedEvents

@saig0
Copy link
Member

saig0 commented May 11, 2020

bors retry

zeebe-bors bot added a commit that referenced this pull request May 11, 2020
4459: fix(clients/java): parse USE_PLAINTEXT_CONNECTION as boolean r=saig0 a=pihme

## Description

Changes behavior of `USE_PLAINTEXT_CONNECTION` flag; If it is explicitly set to `false`, it won't be applied.

## Related issues

closes #4245

#

Co-authored-by: pihme <pihme@users.noreply.github.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented May 11, 2020

Build failed

@saig0
Copy link
Member

saig0 commented May 11, 2020

bors r+

zeebe-bors bot added a commit that referenced this pull request May 11, 2020
4459: fix(clients/java): parse USE_PLAINTEXT_CONNECTION as boolean r=saig0 a=pihme

## Description

Changes behavior of `USE_PLAINTEXT_CONNECTION` flag; If it is explicitly set to `false`, it won't be applied.

## Related issues

closes #4245

#

Co-authored-by: pihme <pihme@users.noreply.github.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented May 11, 2020

Build failed

@pihme
Copy link
Contributor Author

pihme commented May 11, 2020

bors retry

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented May 11, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit 9e1f0d2 into develop May 11, 2020
@zeebe-bors zeebe-bors bot deleted the 4245-env-var-use-plaintext-connection branch May 11, 2020 07:14
github-merge-queue bot pushed a commit that referenced this pull request Apr 16, 2024
…4459)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override ClientProperties.USE_PLAINTEXT_CONNECTION with env variable
3 participants