Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients/java): add user-agent to java client requests #4832

Merged
merged 1 commit into from Jul 8, 2020

Conversation

MiguelPires
Copy link
Contributor

Description

Add user-agent header with client and version information to gRPC and OAuth requests.

Related issues

closes #4265

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing

@MiguelPires MiguelPires requested a review from saig0 June 26, 2020 11:40
@MiguelPires MiguelPires self-assigned this Jun 26, 2020
@MiguelPires MiguelPires force-pushed the 4265-java-usr-agent branch 2 times, most recently from 0addfe0 to 92d6d5d Compare June 30, 2020 09:09
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few comments.

@MiguelPires MiguelPires requested a review from saig0 July 1, 2020 14:30
@MiguelPires
Copy link
Contributor Author

Thanks for the feedback @saig0, I had to rebase on develop due to have the fix for expiring certs in the tests

Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MiguelPires
Copy link
Contributor Author

bors r+

zeebe-bors bot added a commit that referenced this pull request Jul 8, 2020
4832: feat(clients/java): add user-agent to java client requests r=MiguelPires a=MiguelPires

## Description

Add user-agent header with client and version information to gRPC and OAuth requests.

## Related issues

closes #4265 

#

4895: Update dependency io.zeebe:zeebe-client-java to v0.24.0 r=npepinpe a=renovate[bot]

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| io.zeebe:zeebe-client-java | minor | `0.23.3` -> `0.24.0` |

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#zeebe-io/zeebe).

Co-authored-by: Miguel Pires <miguel.pires@camunda.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jul 8, 2020

Build failed (retrying...):

zeebe-bors bot added a commit that referenced this pull request Jul 8, 2020
4832: feat(clients/java): add user-agent to java client requests r=MiguelPires a=MiguelPires

## Description

Add user-agent header with client and version information to gRPC and OAuth requests.

## Related issues

closes #4265 

#

Co-authored-by: Miguel Pires <miguel.pires@camunda.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jul 8, 2020

Build failed:

@MiguelPires
Copy link
Contributor Author

bors r+

zeebe-bors bot added a commit that referenced this pull request Jul 8, 2020
4832: feat(clients/java): add user-agent to java client requests r=MiguelPires a=MiguelPires

## Description

Add user-agent header with client and version information to gRPC and OAuth requests.

## Related issues

closes #4265 

#

Co-authored-by: Miguel Pires <miguel.pires@camunda.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jul 8, 2020

Build failed:

@MiguelPires
Copy link
Contributor Author

bors r+

zeebe-bors bot added a commit that referenced this pull request Jul 8, 2020
4782: chore(broker): handle out of disk space in broker r=deepthidevaki a=deepthidevaki

## Description

* expose configuration parameters for minimum free disk space
* When broker free disk space available is less than configured min free disk,
  - reject client requests
  - reject commands from other partitions
  - pause stream processor

## Related issues

closes #4441 

#

4832: feat(clients/java): add user-agent to java client requests r=MiguelPires a=MiguelPires

## Description

Add user-agent header with client and version information to gRPC and OAuth requests.

## Related issues

closes #4265 

#

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Co-authored-by: Miguel Pires <miguel.pires@camunda.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jul 8, 2020

Build failed (retrying...):

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jul 8, 2020

Build succeeded:

@zeebe-bors zeebe-bors bot merged commit fde9eb3 into develop Jul 8, 2020
@zeebe-bors zeebe-bors bot deleted the 4265-java-usr-agent branch July 8, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java client should send the client type and version with his auth request
4 participants