New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clients/java): add user-agent to java client requests #4832
Conversation
0addfe0
to
92d6d5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few comments.
clients/java/src/main/java/io/zeebe/client/impl/oauth/OAuthCredentialsProvider.java
Outdated
Show resolved
Hide resolved
clients/java/src/main/java/io/zeebe/client/impl/ZeebeClientImpl.java
Outdated
Show resolved
Hide resolved
3eda09f
to
c3bcdfc
Compare
Thanks for the feedback @saig0, I had to rebase on develop due to have the fix for expiring certs in the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
bors r+ |
4832: feat(clients/java): add user-agent to java client requests r=MiguelPires a=MiguelPires ## Description Add user-agent header with client and version information to gRPC and OAuth requests. ## Related issues closes #4265 # 4895: Update dependency io.zeebe:zeebe-client-java to v0.24.0 r=npepinpe a=renovate[bot] This PR contains the following updates: | Package | Update | Change | |---|---|---| | io.zeebe:zeebe-client-java | minor | `0.23.3` -> `0.24.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#zeebe-io/zeebe). Co-authored-by: Miguel Pires <miguel.pires@camunda.com> Co-authored-by: Renovate Bot <bot@renovateapp.com>
Build failed (retrying...): |
4832: feat(clients/java): add user-agent to java client requests r=MiguelPires a=MiguelPires ## Description Add user-agent header with client and version information to gRPC and OAuth requests. ## Related issues closes #4265 # Co-authored-by: Miguel Pires <miguel.pires@camunda.com>
Build failed: |
bors r+ |
4832: feat(clients/java): add user-agent to java client requests r=MiguelPires a=MiguelPires ## Description Add user-agent header with client and version information to gRPC and OAuth requests. ## Related issues closes #4265 # Co-authored-by: Miguel Pires <miguel.pires@camunda.com>
Build failed: |
bors r+ |
4782: chore(broker): handle out of disk space in broker r=deepthidevaki a=deepthidevaki ## Description * expose configuration parameters for minimum free disk space * When broker free disk space available is less than configured min free disk, - reject client requests - reject commands from other partitions - pause stream processor ## Related issues closes #4441 # 4832: feat(clients/java): add user-agent to java client requests r=MiguelPires a=MiguelPires ## Description Add user-agent header with client and version information to gRPC and OAuth requests. ## Related issues closes #4265 # Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com> Co-authored-by: Miguel Pires <miguel.pires@camunda.com>
Build failed (retrying...): |
Build succeeded: |
Description
Add user-agent header with client and version information to gRPC and OAuth requests.
Related issues
closes #4265
Pull Request Checklist
mvn clean install -DskipTests
locally before committing