New instance and job panels #8169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gauge which tried to reflect the running instance count is removed, since it shows inaccurate data especially on fail over or restarts. We will switch to showing rates for creations and completions
The gauge which tried to reflect the pending jobs is removed, since it shows inaccurate data especially on fail over or restarts. We will switch to showing rates for creations and completions
Replace the running instance panel with panels which show the rate of process instance and job creations and panels which show the completion of process instances and jobs
npepinpe
approved these changes
Nov 8, 2021
|
bors r+ |
ghost
pushed a commit
that referenced
this pull request
Nov 8, 2021
8169: New instance and job panels r=Zelldon a=Zelldon ## Description * Remove the process instance gauge, which was used to count the current running instances * Remove the job gauge, which was used to count the pending jobs Boths metrics were error prone, and show misleading numbers if a fail-over or restart happened. To overcome this problem we use now counters, and show only the creation and completion rate separately.  For multi namespace it looks like this:  When we have starter and simple starter running, without workers it looks like this:  <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes #4657 Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
Build failed: |
|
bors r+ |
ghost
pushed a commit
that referenced
this pull request
Nov 8, 2021
8154: 8153 add id attribute for userTaskForm r=korthout a=Lzgabel ## Description Add default id attribute for userTaskForm. ## Related issues closes #8153 8169: New instance and job panels r=Zelldon a=Zelldon ## Description * Remove the process instance gauge, which was used to count the current running instances * Remove the job gauge, which was used to count the pending jobs Boths metrics were error prone, and show misleading numbers if a fail-over or restart happened. To overcome this problem we use now counters, and show only the creation and completion rate separately.  For multi namespace it looks like this:  When we have starter and simple starter running, without workers it looks like this:  <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes #4657 Co-authored-by: lzgabel <lz19960321lz@gmail.com> Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
Build failed (retrying...): |
ghost
pushed a commit
that referenced
this pull request
Nov 8, 2021
8169: New instance and job panels r=Zelldon a=Zelldon ## Description * Remove the process instance gauge, which was used to count the current running instances * Remove the job gauge, which was used to count the pending jobs Boths metrics were error prone, and show misleading numbers if a fail-over or restart happened. To overcome this problem we use now counters, and show only the creation and completion rate separately.  For multi namespace it looks like this:  When we have starter and simple starter running, without workers it looks like this:  <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes #4657 Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Boths metrics were error prone, and show misleading numbers if a fail-over or restart happened. To overcome this problem we use now counters, and show only the creation and completion rate separately.
For multi namespace it looks like this:
When we have starter and simple starter running, without workers it looks like this:
Related issues
closes #4657
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: