test: increment time continuously

[Zelldon]

Description

In order to prevent for flakiness the time needs to be increased
everytime so we can retrigger the position distribution.

Related issues

closes #8475

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

• The changes are backwards compatibility with previous versions
• If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

• There are unit/integration tests that verify all acceptance criterias of the issue
• New tests are written to ensure backwards compatibility with further versions
• The behavior is tested manually
• The change has been verified by a QA run
• The impact of the changes is verified by a benchmark

Documentation:

• The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
• New content is added to the release announcement

[deepthidevaki]

🚀
I don't understand why the event is not received with the first clock increment though.

[Zelldon]

Thanks @deepthidevaki I think this is a good point I can take a deeper look again.

[Zelldon]

Hey @deepthidevaki I had a deeper look and I think I can explain it.

In our test we start the exporters and await the future. The future we await is returned from submitting the Actor, https://github.com/camunda-cloud/zeebe/blob/develop/broker/src/main/java/io/camunda/zeebe/broker/exporter/stream/ExporterDirector.java#L107. Here it becomes interesting.

Taking a look at the actor scheduler, we can see that the future is complete after the starting phase is complete, which means #onActorStarting was called https://github.com/camunda-cloud/zeebe/blob/develop/util/src/main/java/io/camunda/zeebe/util/sched/ActorTask.java#L176

I was able to reproduce this via unit tests:

  @Test
  public void shouldCompleteFutureBeforeStartedComplete() {
    // given
    final CountDownLatch latch = new CountDownLatch(1);
    final var scheduler = ActorScheduler.newActorScheduler().build();

    scheduler.start();

    // when
    final ActorFuture<Void> startedFuture =
        scheduler.submitActor(
            new Actor() {
              @Override
              protected void onActorStarted() {
                try {
                  latch.await();
                } catch (final InterruptedException e) {
                  e.printStackTrace();
                }
              }
            });

    // then
    startedFuture.join();
    assertThat(startedFuture).isDone();
    assertThat(latch.getCount()).isEqualTo(1);
  }

This test completes without issues.

The following test will never complete:

  @Test
  public void shouldCompleteFutureBeforeStartingComplete() {
    // given
    final CountDownLatch latch = new CountDownLatch(1);
    final var scheduler = ActorScheduler.newActorScheduler().build();

    scheduler.start();

    // when
    final ActorFuture<Void> startedFuture =
        scheduler.submitActor(
            new Actor() {
              @Override
              protected void onActorStarting() {
                try {
                  latch.await();
                } catch (final InterruptedException e) {
                  e.printStackTrace();
                }
              }
            });

    // then
    startedFuture.join();
    assertThat(startedFuture).isDone();
    assertThat(latch.getCount()).isEqualTo(1);
  }

So to conclude we already complete the future after the starting phase, after that we wait that the active exporter is in the exporting phase, but this doesn't mean that the passive exporter has completely set up. This means in our test we already increment the time, but the passive exporter might not subscribed yet for the event (this happens in the #onActorStarted) .

[deepthidevaki]

Got it! Thanks for looking into it 👍

[Zelldon]

bors r+

[ghost]

Build succeeded:

• Run smoke tests on macos-latest
• Run smoke tests on ubuntu-latest
• Run smoke tests on windows-latest
• continuous-integration/jenkins/branch

[github-actions]

Backport failed for stable/1.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.2
git worktree add -d .worktree/backport-8508-to-stable/1.2 origin/stable/1.2
cd .worktree/backport-8508-to-stable/1.2
git checkout -b backport-8508-to-stable/1.2
ancref=$(git merge-base 4cbae45566fe59acc44c65c8d8ef65d8434322cf abe53bce920a22add55eb0d8e856589e7f046e1e)
git cherry-pick -x $ancref..abe53bce920a22add55eb0d8e856589e7f046e1e

[github-actions]

Backport failed for release-1.3.0, because it was unable to create a new branch.

Please cherry-pick the changes locally.

git fetch origin release-1.3.0
git worktree add -d .worktree/backport-8508-to-release-1.3.0 origin/release-1.3.0
cd .worktree/backport-8508-to-release-1.3.0
git checkout -b backport-8508-to-release-1.3.0
ancref=$(git merge-base 4cbae45566fe59acc44c65c8d8ef65d8434322cf abe53bce920a22add55eb0d8e856589e7f046e1e)
git cherry-pick -x $ancref..abe53bce920a22add55eb0d8e856589e7f046e1e

[npepinpe]

BTW great catch 💪