-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't wait for actor being submitted #8993
Conversation
316a0cf
to
90b72f1
Compare
90b72f1
to
403942f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 I'm glad that you wrote a test for this.
bors r+
8993: fix: don't wait for actor being submitted r=oleschoenburg a=romansmirnov ## Description * Ensures that the activate jobs handler actor is submitted to the actor scheduler without blocking the actor thread * This requires the usage of `CompletableFuture` to get notified when the handler has been scheduled successfully * That way, the implementation works in case of an embedded and standalone gateway * Adjust test cases to avoid potential race conditions <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes #8992 Co-authored-by: Roman <roman.smirnov@camunda.com>
Build failed: |
bors retry |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.2
git worktree add -d .worktree/backport-8993-to-stable/1.2 origin/stable/1.2
cd .worktree/backport-8993-to-stable/1.2
git checkout -b backport-8993-to-stable/1.2
ancref=$(git merge-base d325919e7eef25f335c735088abb035dbfd58a8d 403942f036cdd9120d153f3f4b25cedd3d36fd13)
git cherry-pick -x $ancref..403942f036cdd9120d153f3f4b25cedd3d36fd13 |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-8993-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-8993-to-stable/1.3
git checkout -b backport-8993-to-stable/1.3
ancref=$(git merge-base d325919e7eef25f335c735088abb035dbfd58a8d 403942f036cdd9120d153f3f4b25cedd3d36fd13)
git cherry-pick -x $ancref..403942f036cdd9120d153f3f4b25cedd3d36fd13 |
Apparently 1.2 does not have same bug. I wanted to just backport this PR but got a lot of conflicts (eg. |
9008: [Backport stable/1.3] fix: don't wait for actor being submitted r=deepthidevaki a=oleschoenburg ## Description Manual backport of #8993 9022: [Backport stable/1.3] chore(maven): add trailing slashes to new Artifactory URL r=oleschoenburg a=github-actions[bot] # Description Backport of #9017 to `stable/1.3`. relates to Co-authored-by: Roman <roman.smirnov@camunda.com> Co-authored-by: Christian Nicolai <christian.nicolai@camunda.com>
Description
CompletableFuture
to get notified when the handler has been scheduled successfullyRelated issues
closes #8992
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: