Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(maven): add trailing slashes to new Artifactory URL #9017

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

cmur2
Copy link
Member

@cmur2 cmur2 commented Mar 29, 2022

Description

I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency.

Related issues

Related to INFRA-3107

@cmur2
Copy link
Member Author

cmur2 commented Mar 29, 2022

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Mar 29, 2022
9017: chore(maven): add trailing slashes to new Artifactory URL r=cmur2 a=cmur2

## Description

I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency.

## Related issues

Related to INFRA-3107

Co-authored-by: Christian Nicolai <christian.nicolai@camunda.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@lenaschoenburg
Copy link
Member

bors retry

zeebe-bors-camunda bot added a commit that referenced this pull request Mar 29, 2022
9009: deps(maven): bump rest-assured from 4.5.1 to 5.0.0 r=npepinpe a=dependabot[bot]

Bumps [rest-assured](https://github.com/rest-assured/rest-assured) from 4.5.1 to 5.0.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/rest-assured/rest-assured/blob/master/changelog.txt">rest-assured's changelog</a>.</em></p>
<blockquote>
<h2>Changelog 5.0.0 (2022-03-25)</h2>
<ul>
<li>Breaking change: REST Assured now builds on Groovy 4!</li>
<li>Excluded example projects from rest assured bom file (issue 1546)</li>
<li>Updated jackson from version 2.11.1 to 2.13.2 (issue 1555)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/rest-assured/rest-assured/commit/2e78356464152ee4b993935f282678ab15628170"><code>2e78356</code></a> [maven-release-plugin] prepare release rest-assured-5.0.0</li>
<li><a href="https://github.com/rest-assured/rest-assured/commit/bffeefe4c238a0b1c1f1a8d16c227036eacfd7fd"><code>bffeefe</code></a> Updated jackson from version 2.11.1 to 2.13.2 (issue 1555)</li>
<li><a href="https://github.com/rest-assured/rest-assured/commit/fd477c599724b19f7361cc12d581446d8eba19c1"><code>fd477c5</code></a> Excluded example projects from rest assured bom file (issue 1546)</li>
<li><a href="https://github.com/rest-assured/rest-assured/commit/3a74c2c10745c295d09acce23728ba354d499a9b"><code>3a74c2c</code></a> Updated changelog to reflect the latest changes</li>
<li><a href="https://github.com/rest-assured/rest-assured/commit/b505d4aaa402176ea70991cddf974bc033b01e46"><code>b505d4a</code></a> Trying ubuntu latest for github actions</li>
<li><a href="https://github.com/rest-assured/rest-assured/commit/d7f0466911082a45b5efb57e33e150789085994d"><code>d7f0466</code></a> Upgrading sundrio plugin</li>
<li><a href="https://github.com/rest-assured/rest-assured/commit/1bc199e79c47d47119096c38a4f6b75f95d280df"><code>1bc199e</code></a> Removed some redundant OSGi package imports and did a few minor other tweaks ...</li>
<li><a href="https://github.com/rest-assured/rest-assured/commit/30a6c96a2cd176c81609f61d772f77b62ef74c16"><code>30a6c96</code></a> Removed downloads link</li>
<li><a href="https://github.com/rest-assured/rest-assured/commit/24614440409d446abaf5bab30993b866ae8d16a4"><code>2461444</code></a> Fixes OSGi itests and corrects groovy import range (<a href="https://github-redirect.dependabot.com/rest-assured/rest-assured/issues/1562">#1562</a>)</li>
<li><a href="https://github.com/rest-assured/rest-assured/commit/4aa8ba7ec09717dd20a32f81aee02cee2aefe0bb"><code>4aa8ba7</code></a> Only build RA on Java 8 since gmaven plugin doesn't seem to play well with 11...</li>
<li>Additional commits viewable in <a href="https://github.com/rest-assured/rest-assured/compare/rest-assured-4.5.1...rest-assured-5.0.0">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=io.rest-assured:rest-assured&package-manager=maven&previous-version=4.5.1&new-version=5.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

9017: chore(maven): add trailing slashes to new Artifactory URL r=cmur2 a=cmur2

## Description

I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency.

## Related issues

Related to INFRA-3107

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christian Nicolai <christian.nicolai@camunda.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed (retrying...):

zeebe-bors-camunda bot added a commit that referenced this pull request Mar 29, 2022
9017: chore(maven): add trailing slashes to new Artifactory URL r=cmur2 a=cmur2

## Description

I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency.

## Related issues

Related to INFRA-3107

Co-authored-by: Christian Nicolai <christian.nicolai@camunda.com>
@cmur2
Copy link
Member Author

cmur2 commented Mar 29, 2022

bors retry

@zeebe-bors-camunda
Copy link
Contributor

Already running a review

@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@cmur2
Copy link
Member Author

cmur2 commented Mar 29, 2022

bors retry

zeebe-bors-camunda bot added a commit that referenced this pull request Mar 29, 2022
8999: Add commit and record write quantile panels r=Zelldon a=Zelldon

## Description

Taking a look at performance issues often forces me at the end to look at the commit latencies, because of #8551 It is currently quite hard to compare latencies from two benchmarks, since this is show as a heatmap. 

![old-panels](https://user-images.githubusercontent.com/2758593/160366627-bfd3e8f3-9c59-4bd6-8831-6df5f4a6e8ca.png)

This PR should solve this issue, and allows me to not always recreate my panels (to see a difference).

It addes two new panels, one for the commit latency and one for the record write latency. Both show the quantiles (p90, p99), the median and the avg. 

The formulars were based on :  https://theswissbay.ch/pdf/Books/Computer%20science/prometheus_upandrunning.pdf (I use the book)


The new panels look like this:

![new-panels](https://user-images.githubusercontent.com/2758593/160366881-52720cfc-1bcd-4d46-8055-27c59a873c64.png)

this allows to easier compare it to other benchmark which perform worse like:

![otherbench-new-panels](https://user-images.githubusercontent.com/2758593/160366975-ffc7ac5d-3488-4ea7-9fd9-0839b365bfb1.png)


<!-- Please explain the changes you made here. -->

## Related issues

<!-- Which issues are closed by this PR or are related -->

related to #8551



9017: chore(maven): add trailing slashes to new Artifactory URL r=cmur2 a=cmur2

## Description

I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency.

## Related issues

Related to INFRA-3107

Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
Co-authored-by: Christian Nicolai <christian.nicolai@camunda.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed (retrying...):

@cmur2
Copy link
Member Author

cmur2 commented Mar 29, 2022

@oleschoenburg can we do anything else apart from retrying?

zeebe-bors-camunda bot added a commit that referenced this pull request Mar 29, 2022
9017: chore(maven): add trailing slashes to new Artifactory URL r=cmur2 a=cmur2

## Description

I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency.

## Related issues

Related to INFRA-3107

Co-authored-by: Christian Nicolai <christian.nicolai@camunda.com>
@lenaschoenburg
Copy link
Member

If this run also fails I can merge directly, no risk of merge conflicts here.

@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@github-actions
Copy link
Contributor

Successfully created backport PR #9021 for stable/1.2.

@github-actions
Copy link
Contributor

Successfully created backport PR #9022 for stable/1.3.

zeebe-bors-camunda bot added a commit that referenced this pull request Mar 29, 2022
9021: [Backport stable/1.2] chore(maven): add trailing slashes to new Artifactory URL r=oleschoenburg a=github-actions[bot]

# Description
Backport of #9017 to `stable/1.2`.

relates to 

Co-authored-by: Christian Nicolai <christian.nicolai@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Mar 29, 2022
9022: [Backport stable/1.3] chore(maven): add trailing slashes to new Artifactory URL r=oleschoenburg a=github-actions[bot]

# Description
Backport of #9017 to `stable/1.3`.

relates to 

Co-authored-by: Christian Nicolai <christian.nicolai@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Mar 29, 2022
9022: [Backport stable/1.3] chore(maven): add trailing slashes to new Artifactory URL r=oleschoenburg a=github-actions[bot]

# Description
Backport of #9017 to `stable/1.3`.

relates to 

Co-authored-by: Christian Nicolai <christian.nicolai@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Mar 30, 2022
9008: [Backport stable/1.3] fix: don't wait for actor being submitted r=deepthidevaki a=oleschoenburg

## Description

Manual backport of #8993 


9022: [Backport stable/1.3] chore(maven): add trailing slashes to new Artifactory URL r=oleschoenburg a=github-actions[bot]

# Description
Backport of #9017 to `stable/1.3`.

relates to 

Co-authored-by: Roman <roman.smirnov@camunda.com>
Co-authored-by: Christian Nicolai <christian.nicolai@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Mar 30, 2022
9022: [Backport stable/1.3] chore(maven): add trailing slashes to new Artifactory URL r=oleschoenburg a=github-actions[bot]

# Description
Backport of #9017 to `stable/1.3`.

relates to 

Co-authored-by: Christian Nicolai <christian.nicolai@camunda.com>
@npepinpe npepinpe added the version:1.2.12 Marks an issue as being completely or in parts released in 1.2.12 label Apr 5, 2022
zeebe-bors-camunda bot added a commit that referenced this pull request Apr 5, 2022
9022: [Backport stable/1.3] chore(maven): add trailing slashes to new Artifactory URL r=oleschoenburg a=github-actions[bot]

# Description
Backport of #9017 to `stable/1.3`.

relates to 

Co-authored-by: Christian Nicolai <christian.nicolai@camunda.com>
@deepthidevaki deepthidevaki added the version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 label May 3, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:1.2.12 Marks an issue as being completely or in parts released in 1.2.12 version:1.3.8 version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants