Fix ArrayOutOfBounds / collection has wrong type errors by raising an incident #9178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pihme
changed the title
saig0
requested changes
Apr 21, 2022
There was a problem hiding this comment.
@pihme thank you for fixing the issue 👍
I just have a few suggestions and one concern about the test. But I like the direction.
I highly recommend testing the behavior manually (if not already done). A manual test can discover odd behaviors sometimes easier than our tests.
...src/main/java/io/camunda/zeebe/engine/processing/bpmn/behavior/OutputCollectionBehavior.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/camunda/zeebe/engine/processing/bpmn/behavior/OutputCollectionBehavior.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/camunda/zeebe/engine/processing/bpmn/behavior/OutputCollectionBehavior.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/camunda/zeebe/engine/processing/bpmn/behavior/OutputCollectionBehavior.java
Outdated
Show resolved
Hide resolved
.../main/java/io/camunda/zeebe/engine/processing/bpmn/container/MultiInstanceBodyProcessor.java
Outdated
Show resolved
Hide resolved
...test/java/io/camunda/zeebe/engine/processing/bpmn/behavior/OutputCollectionBehaviorTest.java
Outdated
Show resolved
Hide resolved
engine/src/test/java/io/camunda/zeebe/engine/processing/incident/MultiInstanceIncidentTest.java
Outdated
Show resolved
Hide resolved
engine/src/test/java/io/camunda/zeebe/engine/processing/incident/MultiInstanceIncidentTest.java
Show resolved
Hide resolved
|
@saig0 Incorporated most of your suggestions. Regarding your rephrasing suggestions I took some liberties. Two are still open for discussion, clarification. |
saig0
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Feel free to merge when you're ready. The major points are solved 👍
We discussed that
- we want to merge the two cases in the incident test to avoid duplication
- we could keep the unit mock test (if you prefer) with the assumption that it would help us to root cause issues.
|
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Apr 26, 2022
9178: Fix ArrayOutOfBounds / collection has wrong type errors by raising an incident r=pihme a=pihme ## Description * Move updating of outbound collection into behavior class * Some refactorings (mostly renames) * Check for index out of bounds, implement tests for it * Check for outbound collection is not an array, implement tests for it ## Related issues closes #9143 Co-authored-by: pihme <pihme@users.noreply.github.com>
|
Build failed: |
- also rename variables to be more descriptive
- also change variables in tests, which had been confused
…cess to outbound collection
|
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Apr 26, 2022
9178: Fix ArrayOutOfBounds / collection has wrong type errors by raising an incident r=pihme a=pihme ## Description * Move updating of outbound collection into behavior class * Some refactorings (mostly renames) * Check for index out of bounds, implement tests for it * Check for outbound collection is not an array, implement tests for it ## Related issues closes #9143 Co-authored-by: pihme <pihme@users.noreply.github.com>
|
bors cancel |
|
Canceled. |
|
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Apr 26, 2022
9178: Fix ArrayOutOfBounds / collection has wrong type errors by raising an incident r=pihme a=pihme ## Description * Move updating of outbound collection into behavior class * Some refactorings (mostly renames) * Check for index out of bounds, implement tests for it * Check for outbound collection is not an array, implement tests for it ## Related issues closes #9143 Co-authored-by: pihme <pihme@users.noreply.github.com>
|
Build failed: |
|
bors merge |
|
Successfully created backport PR #9228 for |
|
Successfully created backport PR #9229 for |
|
This PR fixed also the issue #6953. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
closes #9143
closes #6953
Definition of Done
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: