Set higher timeout for awaitility in ControlledActorClockEndpointIT #9579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning all records, which is printed by awaitility (it doesn't help in this case) we return only the size of the exported record list which we want to assert.
Per default the timeout is around 10 seconds. This might be quite low if we want to archive that during 5 seconds the record size hasn't change. Increasing the timeout makes the test less flaky.
npepinpe
approved these changes
Jun 22, 2022
|
bors r+ |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Jun 22, 2022
9533: deps(maven): bump rest-assured from 5.1.0 to 5.1.1 r=npepinpe a=dependabot[bot] Bumps [rest-assured](https://github.com/rest-assured/rest-assured) from 5.1.0 to 5.1.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rest-assured/rest-assured/blob/master/changelog.txt">rest-assured's changelog</a>.</em></p> <blockquote> <h2>Changelog 5.1.1 (2022-06-10)</h2> <ul> <li>Added support for Spring Framework 6.0 in Spring WebClientTest module</li> <li>Overwrite responseLogDetail when merging ResponseSpecificationImpl (issue 1493) (thanks to petur for pull request)</li> <li>Fix: rootPath does not allow chaining paths with leading operators (issue 1577) (thanks to Roman Mitasov for pull request)</li> <li>Fix: body(InputStream) does not work (issue 1480) (thanks to fedinskiy for pull request)</li> <li>Fix: jsonPath - return null if list(array) does not exists in input document (issue 1544) (thanks to Oleksandr Kulychok for pull request)</li> <li>Fix: Re-added groovy package to package imports for OSGi support (issue 1567) (thanks to Steven Huypens for pull request)</li> <li>Fix: class cast exception in RequestPrinter with byte[] body (thanks to Andreas Grub for pull request)</li> <li>Upgraded gson from 2.6.2 to 2.9.0</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rest-assured/rest-assured/commit/8dd520e58129e441c854723abd080240bc11410b"><code>8dd520e</code></a> [maven-release-plugin] prepare release rest-assured-5.1.1</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/835005e45a898e5e502aea2e48a211d056cb9a6f"><code>835005e</code></a> [ci skip] Preparing changelog for release</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/71c5232eff05d49a3d8b2cba2cbc9787c9af830b"><code>71c5232</code></a> Fixed failing test</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/a70ef2d083076174a18f5eeb0d8cc61cdc5179cf"><code>a70ef2d</code></a> [ci skip] Updated changelog.txt</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/d081c7cb9b87836835fab45eaff88ed0b0d8b614"><code>d081c7c</code></a> Fix class cast exception in RequestPrinter with byte[] body (<a href="https://github-redirect.dependabot.com/rest-assured/rest-assured/issues/1491">#1491</a>)</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/434d59b07fe2c1f7fb50bc9efd48d5ee51fe2271"><code>434d59b</code></a> [ci skip] Updated URL</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/158f6265dd3e7580f45c95a8cd397d85e3c6a85a"><code>158f626</code></a> [ci skip] Updated changelog.txt</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/65db911ae191ca452b290d2c17ca1202e5db5d67"><code>65db911</code></a> setup-java v3 (<a href="https://github-redirect.dependabot.com/rest-assured/rest-assured/issues/1576">#1576</a>)</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/76f6590d49b4d78e79d9b1ef705494166ca4cb25"><code>76f6590</code></a> [ci skip] Updated changelog.txt</li> <li><a href="https://github.com/rest-assured/rest-assured/commit/2a53dccd622ae46fd5e5ca21bc3d85a5a45b897f"><code>2a53dcc</code></a> Fix 1543 - jsonPath: return null if list(array) does not exists in input docu...</li> <li>Additional commits viewable in <a href="https://github.com/rest-assured/rest-assured/compare/rest-assured-5.1.0...rest-assured-5.1.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 9579: Set higher timeout for awaitility in ControlledActorClockEndpointIT r=Zelldon a=Zelldon ## Description * Instead of returning all records, which are printed by awaitility (it doesn't help in this case) we return only the size of the exported record list which we want to assert. This is of course can be discussed, but for me it felt much useful to print all records, because what I want to know in this case is the count/size of the list. * Per default the timeout is around 10 seconds. This might be quite low if we want to archive that during 5 seconds the record size hasn't changed. Increasing the timeout makes the test less flaky. I run it multiple times locally after this change without failure, before it failed quite quickly.  <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes #9499 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
@npepinpe not sure what is happing here with bors 🤔 it blocks the other PRs |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
It seems to have some issues today where the GHA checks never run, so it just times out 😞 I think it's safe to merge manually imo, and bors is quiet now, so I'll do that. |
|
Successfully created backport PR #9584 for |
|
Successfully created backport PR #9585 for |
lenaschoenburg
added
the
version:1.3.11
lenaschoenburg
added
the
version:8.1.0-alpha3
Zelldon
added
the
version:8.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
closes #9499
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.