Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix header typos #276

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Fix header typos #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73cc04e
Fix header typos
Jun 28, 2023
14d37a4
Merge pull request #277 from canada-ca/master
Jun 28, 2023
9e8642d
Update site-menu.md
Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common-design-patterns/global-header/contextual-signin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ title: Contextual Sign in button
</section>
<section>
<h2 id="how">How to implement</h2>
<p>Find working examples and code for implementing the header.</p>
<p>Find working examples and code for implementing the Sign in button.</p>
<h3>GCweb (WET) theme implementation reference</h3>
<p>The implementation reference includes how to configure each element of the header.</p>
<ul>
Expand Down
2 changes: 2 additions & 0 deletions common-design-patterns/global-header/site-menu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@ title: "Theme and topic menu"
</ul>
</li>
</ol>
<h4>Accessibility</h4>
<p>Style the menu button label as capital letters, but write the label in sentence case (Menu), so screen readers don't read each letter individually.</p>
<h3>Visual examples</h3>
<div class="pattern-demo mrgn-tp-lg">
<figure>
Expand Down