Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain filter by tags #4404

Merged
merged 11 commits into from
Mar 17, 2023
Merged

Domain filter by tags #4404

merged 11 commits into from
Mar 17, 2023

Conversation

lcampbell2
Copy link
Collaborator

  • Add dynamic filtering to organization-claimed domains
    image
  • Validation handled to ensure no duplicates or unneeded/impossible conditions
    image
  • filter domains if they status values equal or not equal to any status (pass, info, fail)
    image
  • or filter by whether a domain has/doesn't have a certain tag (i.e. NEW, HIDDEN, etc.)
    image

closes #3803

FestiveKyle
FestiveKyle approved these changes Mar 17, 2023
View reviewed changes
frontend/src/organizationDetails/OrganizationDomains.js Outdated
@@ -137,7 +311,7 @@ export function OrganizationDomains({ orgSlug }) {
/>
<InfoBox
title={t`HTTPS`}
info={t`Shows if the domain meets the Hypertext Transfer Protocol Secure (HTTPS) requirements.`}
info={t`Shows if the domain meets the Hypertext Transfer ol Secure (HTTPS) requirements.`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ol

@lcampbell2 lcampbell2 merged commit c796db3 into master Mar 17, 2023
@lcampbell2 lcampbell2 deleted the domain-filter-by-tags branch March 17, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FestiveKyle FestiveKyle FestiveKyle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add filter tags for search
2 participants
@lcampbell2 @FestiveKyle