Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk modify org domains #4416

Merged
merged 11 commits into from
Mar 24, 2023
Merged

Bulk modify org domains #4416

merged 11 commits into from
Mar 24, 2023

Conversation

lcampbell2
Copy link
Collaborator

  • add mutations for admins and super admins to bulk add/remove domains to/from orgs.
  • added domains can be tagged as NEW/NOUVEAU and HIDDEN
  • removed domains can be ARCHIVED
  • optional "audit" flag to add activity logs for each domain

Comment on lines 37 to 40
type: removeDomainUnion,
description:
'`RemoveDomainUnion` returning either a `DomainResultType`, or `DomainErrorType` object.',
resolve: (payload) => payload,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong return type/ domains not returned for this mutation. Asking for domain info in the gql query returns null:

mutation {
  addOrganizationsDomains(input:{orgId: "ordId", domains: [
    "example1234.com"
  ]}) {
    result {
      ... on DomainResult {
        status
        domain {
          domain
        }
      }
    }
  }
}

returns

{
  "data": {
    "addOrganizationsDomains": {
      "result": {
        "status": "Successfully added 0 domain(s) to some-org.",
        "domain": null
      }
    }
  }
}

Comment on lines 31 to 36
result: {
type: GraphQLNonNull(removeDomainUnion),
description:
'`RemoveDomainUnion` returning either a `DomainResultType`, or `DomainErrorType` object.',
resolve: (payload) => payload,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same situation as the add-organizations-domains mutation return value

@lcampbell2 lcampbell2 merged commit e9a8a90 into master Mar 24, 2023
@lcampbell2 lcampbell2 deleted the bulk-modify-org-domains branch March 24, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants