[Proposal] Remove dist folder and its content from git for the v4 #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
added
v4.0.0
peaBerberian
force-pushed
the
next-v4
branch
3 times, most recently
from
7510179
to
cb747b7
Compare
peaBerberian
force-pushed
the
misc/remove-compiled-builds-from-git
branch
from
8a5c871
to
1a262df
Compare
peaBerberian
force-pushed
the
next-v4
branch
from
fa9ef07
to
a3d16f0
Compare
Add `trackInfo` property to some `MediaError`
Add `trackInfo` property to some `MediaError`
Add `trackInfo` property to some `MediaError`
This is a proposal for something I wanted to do for a long time but
didn't for legacy reasons.
Today builds, which are parts of the `dist/` folder at the root of this
repository, are stored and its update committed through git, alongside the
rest of the code.
This means that people cloning or even just browsing the repo is going
to be polutted by megabytes and megabytes of uninteresting bundled code
which can already be built on demand through our bundling dependencies
(I hope deterministically? Or at least not different in ways that
matters?).
Removing the dist folder completely would have the following pros, at
least to me:
- no need to store the bundle through git and its mostly uninteresting
and large diffs, which may lead to a future gain in storage space,
though I don't know what the proportions are (chances are they're
very small, but still).
- When using git tools or tools relying on files like `.gitignore`
(e.g. the searching tool ripgrep - which I use daily. I think that
VSCode also rely on it or at least it could last time I read about
it - for the lost and sad people that are not on vim/neovim yet).
Before, using those tools on the whole repo without explicitely
discarding the `dist` directory would lead to a lot of polution,
especially in search.
- It un-clutters the repository. I like the idea of being able to
understand its structure just by browsing it and one less directory
is a nice step towards that goal.
Yet it has the following cons I can think of:
- It removes the previous possibility of just looking at the build on
github and copy-pasting the bundle's code. Which some did on very
fast tests in the past.
- It leads to the necessity of first bundling the rx-player before
doing things like `npm link`/`yarn link` or other tools/scripts that
I'm not thinking of right now.
peaBerberian
force-pushed
the
misc/remove-compiled-builds-from-git
branch
from
1a262df
to
dd452c8
Compare
peaBerberian
added a commit
that referenced
this pull request
Sep 22, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 26, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 26, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 26, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 26, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 27, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 27, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 27, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Sep 29, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
Merged
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Oct 19, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Oct 26, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Oct 26, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Oct 26, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
peaBerberian
added a commit
that referenced
this pull request
Nov 7, 2023
…rom-git [Proposal] Remove dist folder and its content from git for the v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for something I wanted to do for a long time but didn't for legacy reasons.
Today builds, which are parts of the
dist/folder at the root of this repository, are stored and its update committed through git, alongside the rest of the code.This means that people cloning or even just browsing the repo is going to be polutted by megabytes of uninteresting bundled code which can already be built on demand through our bundling dependencies (I hope deterministically? Or at least not different in ways that matters?).
Removing the dist folder completely would have the following pros, at least to me:
no need to store the bundle through git and its mostly uninteresting and large diffs, which may lead to a future gain in storage space, though I don't know what the proportions are (chances are they're very small, but still).
When using git tools or tools relying on files like
.gitignore(e.g. the searching tool ripgrep - which I use daily. I think that VSCode also rely on it or at least it could last time I read about it - for the lost and sad people that are not on vim/neovim yet).Before, using those tools on the whole repo without explicitely discarding the
distdirectory would lead to a lot of polution, especially in search.It un-clutters the repository. I like the idea of being able to understand its structure just by browsing it and one less directory is a nice step towards that goal.
Yet it has the following cons I can think of:
It removes the previous possibility of just looking at the build on github and copy-pasting the bundle's code. Which some did on very fast tests in the past.
It leads to the necessity of first bundling the rx-player before doing things like
npm link/yarn linkor other tools/scripts that I'm not thinking of right now.We have to check if it doesn't break anything I did not think about