Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trackInfo property to some MediaError #1241

Merged
merged 6 commits into from
May 16, 2023

Conversation

peaBerberian
Copy link
Collaborator

@peaBerberian peaBerberian commented May 2, 2023

This PR adds a trackInfo property to MediaError errors when its code property is set to either:

  - "NO_PLAYABLE_REPRESENTATION" (unplayable track based on DRM policy non-compliance),

  - "MANIFEST_INCOMPATIBLE_CODECS_ERROR" (track with unsupported codec),

  - "BUFFER_APPEND_ERROR" (error while pushing a segment)

  - "BUFFER_FULL_ERROR" (error while pushing a segment which seems specifically linked to that buffer not having enough memory space left)

 That trackInfo property provides characteristics about the track linked to the error. For example, the video track's characteristics when a BUFFER_APPEND_ERROR is linked to a video segment.


The idea here mainly is to allow applications to develop much more powerful error management logic:

  • allowing logs of better errors. For example by knowing if an error was linked to a video or audio track and which one.

  • letting the application add resilience in the context of rare issues it empirically observed, that are most of the time linked to both device issues and the contents being played.

    For example, if an application observes that a device's low level bug lead to the impossibility to play for some contents a video track under the PlayReady SL3000 key system, but that playing another video track do work, the application may want to reload the content after the error was received, this time filtering the problematic video track (if this example looks VERY specific, it's because it's one of the situation we did actually encounter! Issues encountered are multiple and for the most part only linked to some device, contents and DRM policies combinations).

    We also thought about handling all those cases on the RxPlayer-side, but some of those appear to be very specific to the contents being played. We thus decided to also let the application develop its own code if it wants to, allowing much more flexibility and reactivity.

@peaBerberian peaBerberian force-pushed the feat/track-info-on-media-error branch from 4018b4d to 5b4a67d Compare May 2, 2023 17:21
@peaBerberian peaBerberian force-pushed the feat/track-info-on-media-error branch from a2b8bcd to 25bb55d Compare May 3, 2023 12:08
@peaBerberian peaBerberian force-pushed the feat/track-info-on-media-error branch from 25bb55d to 7b9b451 Compare May 3, 2023 12:56
@peaBerberian peaBerberian changed the base branch from master to next May 16, 2023 13:34
@peaBerberian peaBerberian added the API Relative to the RxPlayer's API label May 16, 2023
@peaBerberian peaBerberian added this to the 3.31.0 milestone May 16, 2023
@peaBerberian peaBerberian merged commit 708b366 into next May 16, 2023
peaBerberian added a commit that referenced this pull request May 17, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request May 17, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request May 17, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jun 2, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jun 2, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jun 2, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jun 2, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jun 2, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jun 2, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jun 12, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jun 12, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jun 12, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jun 12, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jun 13, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jun 13, 2023
Add `trackInfo` property to some `MediaError`
@peaBerberian peaBerberian mentioned this pull request Jun 13, 2023
peaBerberian added a commit that referenced this pull request Jun 14, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian added a commit that referenced this pull request Jan 23, 2024
Add `trackInfo` property to some `MediaError`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Relative to the RxPlayer's API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant