React refactor UI v2 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed with Alex, the info previously gleaned via user forms will most likely be inferred by the server based on the gene, so this component structure will change significantly
Can only select values without slashes (need to do some encodeURI stuff to fix)
Styling, built additional screens, incorporated theme context structure
dnd working as expected, component still needs styling
Need to think about using component ID's for rearranging the structure array
Still need to simulate a separate request for the list of domains associated with gene entries.
jsstevenson
requested changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging react-refactor-ui-v2 into staging (creating individual "Issue" branches going forward)