Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a sqlalchemy using parameters instead url #70

Closed
piraz opened this issue Oct 22, 2015 · 0 comments
Closed

Define a sqlalchemy using parameters instead url #70

piraz opened this issue Oct 22, 2015 · 0 comments
Assignees

Comments

@piraz
Copy link
Contributor

piraz commented Oct 22, 2015

Define a sqlalchemy using parameters instead url.

Paremeters are:

  • db or database
  • driver
  • host
  • pass or password
  • port
  • user or username

This method will be helpful when we have a '@'(for instance) in the password. With the url parameter only that will cause an error while connecting to the database. The password will be always url quoted to avoid this kind of problem.

We could fix the url also but that this will be covered in another ticket.

For an url based datasorce like this:

data:
  sources:
    - name: storage
      connector: sqlalchemy
      dialect: postgresql+psycopg2://myuser:thepassword@127.0.0.1:5432/thedatabase

We can use this kind of representation:

data:
  sources:
    - name: storage
      connector: sqlalchemy
      dialect: postgresql
      driver: psycopg2
      username: myuser
      password: thepassword
      host: 127.0.0.1
      port: 5432
      database: thedatabase

The strategy here is to convert the parameters to it's respective url notation with password being always url quoted.

Let's do the happy path with this ticket and handle mandatory parameters exceptions later.

@piraz piraz self-assigned this Oct 22, 2015
@piraz piraz modified the milestones: firenado 0.1.2, firenado 0.1.3 Oct 22, 2015
@piraz piraz modified the milestones: firenado 0.1.4, firenado 0.1.3 Dec 24, 2015
@piraz piraz modified the milestones: firenado 0.1.4, firenado 0.1.5 Apr 1, 2016
@piraz piraz removed this from the firenado 0.1.5 milestone May 30, 2016
@piraz piraz added this to the Backlog milestone Aug 28, 2016
@piraz piraz modified the milestones: Backlog, firenado 0.1.7.4 Nov 3, 2018
@piraz piraz modified the milestones: firenado 1.1, firenado 1.0 Dec 16, 2019
@piraz piraz modified the milestones: firenado 0.2, Backlog Aug 20, 2020
@piraz piraz modified the milestones: Backlog, TODO Jan 15, 2021
@piraz piraz modified the milestones: TODO, firenado 0.2.13 Oct 31, 2021
piraz added a commit to piraz/firenado that referenced this issue Oct 31, 2021
This is a side effect from candango#70 that added the data source name
parameter to the config_to_data_source method.
@piraz piraz closed this as completed in a58d6bc Oct 31, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant