Limit the number of binds per consumer that can run concurrently. #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awood
force-pushed
the
awood/consumer-job-throttle
branch
2 times, most recently
from
f9f17bd
to
8b17a97
Compare
| @@ -82,9 +89,33 @@ public static JobDetail bindByPool(String poolId, Consumer consumer, Integer qty | |||
| JobDetail detail = newJob(EntitlerJob.class) | |||
| .withIdentity("bind_by_pool_" + Util.generateUUID()) | |||
| .requestRecovery(false) // do not recover the job upon restarts | |||
| .storeDurably() | |||
There was a problem hiding this comment.
Any particular reason why you had to set this? Just curious.
There was a problem hiding this comment.
It's required for trigger-less jobs. You get an error if it is not set.
|
retest this please |
|
To make sure that I understand this PR, you are basically checking how many EntitlerJobs are running for an Owner, and if the threshold is reached, queue the job to be executed later? |
|
@awood If my understanding of the PR above is correct, then this looks Ok to me. Couple of things:
|
Binds can take a long time due to the calculation of compliance rules. If we don't throttle the number of concurrent bind jobs, it is likely that some of the jobs will time out waiting to acquire a write-lock in the database. This commit changes Pinsetter to only run a configurable number of bind jobs concurrently. Any jobs above the threshold are temporarily paused.
|
ACK. |
awood
force-pushed
the
awood/consumer-job-throttle
branch
from
8b17a97
to
62a9dd8
Compare
mstead
added a commit
that referenced
this pull request
Dec 2, 2015
Limit the number of binds per consumer that can run concurrently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan on submitting this as a PR to master as well.