1292877: Do not delete dev pool before we are done with it #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we were deleting the dev pool before the derived products were loaded (lazy), we couldn't look them up when addressing modified entitlements. Moved the dev pool deletion to the end of the remove entitlement process to be sure we were done with it.
|
buildbot: retest this please |
|
ack |
wottop
added a commit
that referenced
this pull request
Dec 21, 2015
…issue 1292877: Do not delete dev pool before we are done with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we were deleting the dev pool before the derived products
were loaded (lazy), we couldn't look them up when addressing
modified entitlements.
Moved the dev pool deletion to the end of the remove entitlement
process to be sure we were done with it.