1338950: prevent successful concurrent imports #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@candlepin-pull-request-bot re-test this please |
|
Would be nice for commit message / PR description to have some context as to what the change does. |
|
@mstead done |
|
conditional ack: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in 0.9.54, there is a rare chance ( not reproducable ) that two concurrent reports can result in two records in the cp_export_metadata table for the same "type" . Given the current code, this prevents any future manifest activity ( delete / import / refresh ) because our query expects there to be a unique owner and type ( user / system ) combination for every record.
we are adding a constraint that prevents this situation in the reported branch. in candlepin 2.0, we shall lock the owner and more.
more details in the bz!