1399768: Make pool exported count calculation lazy #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnabycourt
force-pushed
the
pool_exported
branch
from
f791beb
to
6d36619
Compare
barnabycourt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading entitlements forces a pool load. Because this is done with a left join on pool which triggers the exported calculation an extraordinary amount of time is spent in the entitlement fetch (500ms for medium/large database). Under large amounts of load this is having a cascading effect of slowing down everything.
The risk with this is that areas of code that rely on the exported count will trigger additional calls to the databse. Where pools are acted on in bulk there is additional risk (manifest import specifically).