1464133: Put guestId param in consumer json for virtWho instances #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wottop
force-pushed
the
wottop/1458674-2.0
branch
from
981ca5e
to
fbecec4
Compare
|
retest this please |
wottop
force-pushed
the
wottop/1458674-2.0
branch
from
fbecec4
to
41a0826
Compare
wottop
changed the title
Ceiu
reviewed
Jun 26, 2017
| * @return List always empty | ||
| */ | ||
| @JsonProperty("guestIds") | ||
| public List getEmptyGuestIdArray() { |
There was a problem hiding this comment.
(duplicate comment, sorry)
Are we ever going to use this property going forward? If so, does it make sense to just call this "getGuestIDs" and have it always return an empty array until we need it to do otherwise? Maybe the doc block is enough documentation here.
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.