[M] Improved error output surrounding owner creation and service levels #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed a bug that caused the errors that occurred during owner creation to be lacking the owner key in the error message - OwnerResource.createOwner now checks that the owner key is set before attempting to create the owner - OwnerResource.createOwner now checks that the default service level is not set before attempting to create the owner
|
This PR is the changes that came from discussion and investigation of the issue mentioned in BZ 1563003. Since we are not changing the behavior back to the old, incorrect behavior, this commit does not make a reference to the BZ in question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creation to be lacking the owner key in the error message
before attempting to create the owner
level is not set before attempting to create the owner