[2.4] 1584258: Detach consumers from persistence context to avoid OOM - ENT-583 #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before:
After:
|
barnabycourt
changed the title
Updating the status of a large number of consumers (roughly 10000) could run the JVM out of memory due to all the consumers referenced in the consumerStackedEnts map. During status calculation, the consumer facts are accessed and during those accesses, the Hibernate proxy object is replaced by the actual map of facts. The consumerStackedEnts map would accordingly grow as each status was calculated. This patch detaches several model objects as soon as we stop needing them and most importantly, it detaches all the consumers in the consumerStackedEnts map. The consumers are then fetched again, receive an updated status, and are then immediately detached to keep the persistence context at roughly a constant size.
awood
force-pushed
the
awood/1584258-oom-2.4
branch
from
90eae2c
to
f4eb700
Compare
- Added a new method, getConsumers(Collection), to ConsumerCurator for performing bulk consumer fetching/lookup - Updated the consumer status recalculation loop in CPM.deletePools to use the bulk consumer lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the status of a large number of consumers (roughly 10000) could
run the JVM out of memory due to all the consumers referenced in the
consumerStackedEnts map. During status calculation, the consumer facts
are accessed and during those accesses, the Hibernate proxy object is
replaced by the actual map of facts. The consumerStackedEnts map would
accordingly grow as each status was calculated.
This patch detaches several model objects as soon as we stop needing
them and most importantly, it detaches all the consumers in the
consumerStackedEnts map. The consumers are then fetched again, receive
an updated status, and are then immediately detached to keep the
persistence context at roughly a constant size.