1640215: Fix incorrect partial compliance status on consumers #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ceiu
reviewed
Nov 5, 2018
| @@ -140,19 +139,21 @@ public SystemPurposeComplianceStatus getStatus(Consumer consumer, | |||
| } | |||
| unsatisfiedAddons.removeAll(addonsFound); | |||
|
|
|||
| if (product.hasAttribute(Product.Attributes.SUPPORT_LEVEL)) { | |||
| if (StringUtils.isNotEmpty(preferredSla) && | |||
There was a problem hiding this comment.
If there's something else to fix in this PR, we could also reorganize this code a bit to only do this check once. Both of the places it was added to could be nested within a single check, since both are contingent on it being non-empty.
There was a problem hiding this comment.
I'm not sure I understand. One spot is StringUtils.isNotEmpty(preferredSla) and the other is StringUtils.isNotEmpty(preferredUsage).
There was a problem hiding this comment.
Oof... disregard. This is what happens when I review code while dealing with migraine-induced double vision.
If a consumer does not specify a syspurpose attribute (role, usage, etc.), do not mark them partially compliant if they attach to a pool that provides that attribute. This commit also fixes a Jackson error that I discovered while writing the test cases. Jackson was attempting to deserialize compliance reason JSON to a Map<String, String> when the JSON had arrays as the values instead.
awood
force-pushed
the
awood/1640215-partial-compliance-on-empty-preference
branch
from
f77df19
to
71141e3
Compare
This was referenced Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a consumer does not specify a syspurpose attribute (role, usage,
etc.), do not mark them partially compliant if they attach to a pool
that provides that attribute.
This commit also fixes a Jackson error that I discovered while writing
the test cases. Jackson was attempting to deserialize compliance reason
JSON to a Map<String, String> when the JSON had arrays as the values
instead.