Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-2134: 1806575 - GET /owners/{owner_key}/pools is very slow #2623

Merged

Conversation

sonalidhome
Copy link
Contributor

@nikosmoum
Copy link
Member

Tests are failing here because the docker registry URL hadn't been updated on this branch yet. I just pushed the fix in #2624 now, so you need to rebase this PR to get it working.

@sonalidhome sonalidhome changed the title ENT-2134: 1806575 - GET /owners/{owner_key}/pools is very slow ENT-2134: 1806578 - GET /owners/{owner_key}/pools is very slow Feb 25, 2020
@sonalidhome sonalidhome changed the title ENT-2134: 1806578 - GET /owners/{owner_key}/pools is very slow ENT-2134: 1806575 - GET /owners/{owner_key}/pools is very slow Feb 25, 2020
@sonalidhome
Copy link
Contributor Author

Rebased with candlepin:candlepin-2.9-HOTFIX branch.

- Added @transactional annotation to the method listPools()
@Ceiu
Copy link
Contributor

Ceiu commented Feb 25, 2020

Do you happen to have a measure of how fast the method is before and after this change?

@sonalidhome
Copy link
Contributor Author

I compared the snapshot of API with and without @transactional annotation. The time taken to execute with @trasactional is 79802 ms, and, for existing is 147762 ms. Applied annotation on API, the execution is getting a little faster.

@barnabycourt
Copy link
Contributor

@Ceiu on my test system this took 12 minutes before the change and 17 seconds after with the customer data set.

@nikosmoum nikosmoum merged commit 1288843 into candlepin:candlepin-2.9-HOTFIX Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants