Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the metadata into setup.cfg #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KOLANICH
Copy link

Added pyproject.toml
Version is now taken from git tags using setuptools_scm

Copy link
Collaborator

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR. Unfortunately your PR breaks CI tests of RPM builds. It will be necessary to add BuildRequires: python3-setuptools_scm to python-iniparse.spec file. I hope that it will be necessary to change only this.

@KOLANICH
Copy link
Author

Thanks, done.

@jirihnidek
Copy link
Collaborator

/packit build

@jirihnidek
Copy link
Collaborator

This still does not work as expected. The installation script tries to create e.g. UNKNOWN.egg-info instead of python-iniparse.egg-info, etc. and building of RPM is failing for this reason. The setup.cfg is incomplete or there is bug in setuptools_scm.

BTW: the method setuptools_scm.get_version() returns 0.6.dev11+g6145d7c.d20220525 or 0.4. It depends on the file provided as a argument. I do not consider this as anything useful nor reliable. The current version is 0.5. I would like to have this under control and I really don't need to "chase" some fuzzy tool.

I'm considering closing this PR, because CI is still failing for reasons mentioned above.

Added pyproject.toml

Co-Authored-by: Jiri Hnidek <jhnidek@redhat.com>
@KOLANICH
Copy link
Author

Removed setuptools_scm from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants