1288626: Does not report pool ids as serial numbers, ignore duplicates #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,7 +54,8 @@ | |||
| parse_baseurl_info, format_baseurl, is_valid_server_info, \ | |||
| MissingCaCertException, get_client_versions, get_server_versions, \ | |||
| restart_virt_who, get_terminal_width, print_error, \ | |||
| ProductCertificateFilter, EntitlementCertificateFilter | |||
| ProductCertificateFilter, EntitlementCertificateFilter, \ | |||
| unique_list_items | |||
There was a problem hiding this comment.
Put up a few lines ith the other method names. More readable.
|
Other than the minor comments above, ack. |
cnsnyder
force-pushed
the
csnyder/1288626_Do_not_display_pool_ids_as_serials
branch
from
878be82
to
98a7cc7
Compare
|
@wottop I have updated the PR according to your comments above. |
cnsnyder
force-pushed
the
csnyder/1288626_Do_not_display_pool_ids_as_serials
branch
from
98a7cc7
to
c8e5d1b
Compare
|
ack |
wottop
added a commit
that referenced
this pull request
Dec 14, 2015
…y_pool_ids_as_serials 1288626: Does not report pool ids as serial numbers, ignore duplicates
wottop
deleted the
csnyder/1288626_Do_not_display_pool_ids_as_serials
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.