Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rct cat-manifest to print virt_limit attribute #1420

Closed

Conversation

sideangleside
Copy link
Contributor

Add support for rct cat-manifest to print virt_limit attribute. This attribute helps the user determine if virt-who is required.

Additionally, output a new 'Requires virt-who field' set to

  • False - if VIRT_LIMIT attribute == 0 or is nil/None
  • True - otherwise

Example output:

        Name: Red Hat Enterprise Linux Server, Premium (4 sockets) (Unlimited guests)
        Quantity: 50
        Created: 2015-09-07T10:51:26.000+0000
        Start Date: 2015-08-26T04:00:00.000+0000
        End Date: 2016-08-26T03:59:59.000+0000
        Service Level: Premium
        Service Type: L1-L3
        Architectures: x86_64,ppc64le,ppc64,ia64,ppc,x86,s390,s390x
        SKU: *****
        Contract: *****
        Order: *****
        Account: *****
        Virt Limit: unlimited
        Requires Virt-who: True

Add 'Requires virt-who' field based on virt_limit attribute
@wottop wottop self-assigned this Jun 13, 2016
@wottop
Copy link
Contributor

wottop commented Jun 13, 2016

Fails nosetest
subscription-manager/test/test_rct_manifest_command.py", line 74, in test_cat_manifest

@barnabycourt
Copy link
Contributor

@candlepin-pull-request-bot test this please

1 similar comment
@barnabycourt
Copy link
Contributor

@candlepin-pull-request-bot test this please

@Ceiu
Copy link
Contributor

Ceiu commented Jul 26, 2016

@candlepin-pull-request-bot retest this please

@Ceiu
Copy link
Contributor

Ceiu commented Jul 26, 2016

Looks like this is failing because the associated tests haven't been updated to expect the new entry. Please update the appropriate tests and push the changes for this PR.

@awood
Copy link
Contributor

awood commented Aug 4, 2016

Obviated by #1464

@awood awood closed this Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants