Anaconda addon: setup() and execute() no longer get instclass #2092
Conversation
|
Can one of the admins verify this patch? |
|
Note, this will only work with newer anaconda versions. If you want the code to be compatible with both older and newer anaconda, we'd have to do something a bit uglier, like just making the last two arguments to the methods optional (in theory we should then figure out from how many arguments were passed what the arguments actually were and handle them appropriately, but since both these methods basically do nothing, we probably wouldn't need to bother). |
AdamWill
force-pushed
the
addon-no-instclass
branch
from
e30fea9
to
de42682
Compare
|
OK, so I noticed that it seems we use the latest version of subscription-manager for old Fedora releases, so I went ahead and tweaked this to work with both old and new anaconda. |
|
@candlepin-bot ok to test |
| # (storage, ksdata, payload). If this method *did* | ||
| # anything we would have to figure out which args we'd got and | ||
| # handle them appropriately, but since it does nothing, we | ||
| # don't have to bother with that. |
There was a problem hiding this comment.
I'm not native English speaker, but please, can you change the comment to use little bit better English grammar?
| # (storage, ksdata, users, payload). If this method *did* | ||
| # anything we would have to figure out which args we'd got and | ||
| # handle them appropriately, but since it does nothing, we | ||
| # don't have to bother with that. |
|
Um...I am a native English speaker and there's nothing wrong with the grammar. :) If you don't like it for some reason I can rewrite it some other way, though. |
Since anaconda commit rhinstaller/anaconda@78fd1e82 , anaconda addons should no longer expect an install class to be passed to their setup() and execute() methods. Without this fix, the addon breaks recent versions of anaconda. As the policy for this tool seems to be that the most recent version is sent to all Fedora releases (and RHEL releases?), I implemented this in such a way that it will work with both old and new anaconda. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1713109 Signed-off-by: Adam Williamson <awilliam@redhat.com>
AdamWill
force-pushed
the
addon-no-instclass
branch
from
de42682
to
10da7ef
Compare
Uh, I'm sorry. :-) I'm probably too old and I expect at least uppercase letter at the beginning of the sentence and... Never mind. It's only comment. I'm merging it to master. |
|
Oh, I see. Yeah, I often start comments with a lower-case character, not sure why really, it often just reads odd to me for them to start with a capital. I guess to me an in-line comment reads like it's somehow part of "the same sentence" as the code it's commenting on, quite often, rather than being a separate thing... |
Since anaconda commit
rhinstaller/anaconda@78fd1e82 ,
anaconda addons should no longer expect an install class to be
passed to their setup() and execute() methods. Without this fix,
the addon breaks recent versions of anaconda.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1713109
Signed-off-by: Adam Williamson awilliam@redhat.com