Ejabberd: Room is not opened when subject-message arrives

[mweibel]

in Candy.View.Observer.Message.update with type = subject, it can happen that the room is not opened yet, when the subject message arrives.
Due to that, a javascript error happens and no one sees the messages.

[singlespeedfahrer]

I "reopen" this bug report because it is already present on my system.

If I change chat subject in a xmpp client like gajim and after changing I log in with candy all messages are shown. If I log in with candy some time later this bug occurs again, No message is shown in candy. If no subject is present all is ok.

Candy version is from dev branch.

I recieve this JavaScript error after enabling debugging and candy.bundle.js:

  function() - error -
TypeError: self.Room.getPane(roomJid, ".message-pane") is undefined
[Bei diesem Fehler anhalten] self.Room.getPane(roomJid, '.message-pane').append(html);
candy.bundle.js (Zeile 3482)
self.Room.getPane(roomJid, ".message-pane") is undefined
libs.min.js (Zeile 1)
[Jabber] Presence
candy.bundle.js (Zeile 155)
[Jabber:Room] Presence
candy.bundle.js (Zeile 155)
[Jabber] Presence
candy.bundle.js (Zeile 155)
[Jabber:Room] Presence
candy.bundle.js (Zeile 155)
[Jabber] Presence
candy.bundle.js (Zeile 155)
[Jabber:Room] Presence
candy.bundle.js (Zeile 155)
[Jabber:Room] Disco
candy.bundle.js (Zeile 155)
[Jabber] PrivacyList
candy.bundle.js (Zeile 155)
[Jabber] Presence

Sorry, don't know how to enable syntax highlighting.

[pstadler]

It's fixed in the dev branch. Download the latest version here: https://github.com/amiadogroup/candy/zipball/dev

[mweibel]

Can you post the message-chain you receive? (Please note that you should censor private information)

[singlespeedfahrer]

Thanks for your answers.

@pstadler: I thought I installed latest dev branch. Now I have installed version from your link and will observe if the error occurs again.

@mweibel: After installing candy from newest dev branch the error hasn't occured yet. If it should appear again I will post it with message chain.

[singlespeedfahrer]

The error occured again.

Don't know what exactly is importent for you to know from all the bug tracking messages. I copied all messages beginning with login. JavaScript error is shown in line 118:

http://pastebin.com/Vc1yJTUS

[mweibel]

Just a note: you should erase the content of the challenge response on line 37 :)

After a quick glance it seems you receive a lot of pubsub messages which do not belong to us. The first real message you receive is not even a subject, so I think that's another bug.

The question is why this happens. Maybe the bug lies in Candy.View.Observer.Message where it only checks if the room has been opened if the message is a private chat message.

[singlespeedfahrer]

Thanks for your hint ;).

Because you suggested that this issue could be caused by my ejabberd, I downgraded ejabberd from 2.1.6 (self build debian testing backport for squeeze) to official squeeze release 2.1.5 yesterday evening. Even after the error hasn't been occured yet. Before downgrading ejabberd this error occured mostly 1-2 hours after changing subject or restarting ejabberd.

I will observe this but I have no clue how I can trace the error at best. Perhaps I will make an attempt to install current ejabberd version 2.1.8.x. I have updated ejabberd to version 2.1.6 because of its captcha and website account creation feature.

[singlespeedfahrer]

Some hours ago I built a debian squeeze backport of current ejabberd version 2.1.8. Since restarting ejabberd the error hasn't occured yet. Hope that was it!

[mweibel]

@houwe: How's the current status?

[singlespeedfahrer]

Since updating ejabberd the error hasn't occured yet. Don't know why ;) but it seems to be that this error is away.

[mweibel]

Good to know.

@pstadler: What do you think about this issue? Should we consider anyway to fix it? Because it seems to happen in 2.1.6...

[pstadler]

Let's close this.