Clean things up some #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `view` instead of `splitAt`. * Use pattern guards to clarify. * Remove redundant constraints. * Make the constructor strict, which is semantically correct and should make things easier for the optimizer. * Get rid of the existential quantification. This is a breaking change, but I think it's the Right Thing. It should reduce help the specializer a lot and sometimes reduce allocation. Almost no other packages use an existential the way this did. * Generalize the type of `median` to produce non-`Double` results. * Add a version of `median` specialized to the case where the element type is the same as the result type. * Get rid of `popAndSwap`. Inlining it removes an incomplete pattern match and I think also makes the code significantly clearer. * Document invariants. * Make the test suite fail properly when things are broken.
Because we can.
|
The CI failures are not my fault. It looks like some dependencies need to be updated upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewinstead ofsplitAt.and should make things easier for the optimizer.
change, but I think it's the Right Thing. It should
help the specializer a lot and sometimes reduce allocation.
Almost no other packages use an existential the way this did.
medianto produce non-Doubleresults.medianspecialized to the case where the elementtype is the same as the result type.
popAndSwap. Inlining it removes an incompletepattern match and I think also makes the code significantly
clearer.