Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode/decode :raw bindings #21

Closed
chasenlehara opened this issue May 7, 2018 · 1 comment
Closed

Encode/decode :raw bindings #21

chasenlehara opened this issue May 7, 2018 · 1 comment
Assignees

Comments

@chasenlehara
Copy link
Member

Right now, encode("nameProp:raw") returns "nameProp:raw" when I think it should return "name:u:prop:raw".

I think support for :raw needs to be added to encode:

// - on:fooBar, fooBar:to, fooBar:from, fooBar:bind
if (startsWith(encoded, 'on:') || endsWith(encoded, ':to') || endsWith(encoded, ':from') || endsWith(encoded, ':bind')) {

…and decode:

if (startsWith(decoded, 'on:') || endsWith(decoded, ':to') || endsWith(decoded, ':from') || endsWith(decoded, ':bind')) {

This came up because of a question @pYr0x asked on Gitter: https://gitter.im/canjs/canjs?at=5af0bb0459a0578004b08c89

@pYr0x pYr0x self-assigned this May 7, 2018
m-mujica added a commit that referenced this issue May 14, 2018
@m-mujica m-mujica self-assigned this May 14, 2018
@m-mujica
Copy link
Contributor

@pYr0x had to take this one from you, hope you don't mind ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants