Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour Hooks not calling super() #76

Closed
christopherjbaker opened this issue Jun 26, 2017 · 3 comments
Closed

Behaviour Hooks not calling super() #76

christopherjbaker opened this issue Jun 26, 2017 · 3 comments

Comments

@christopherjbaker
Copy link

None of the hooks on either behaviour call the super equivalent on tho previous behaviour. I believe each should have baseConnect.<hook>.apply(this, arguments);, or am I mistaken?

@green3g
Copy link
Contributor

green3g commented Jan 16, 2018

Yep, this appears to be a bug. It prevents the other behaviors from working.

Like this line fails:

https://github.com/canjs/can-connect-feathers/blob/master/session/session.js#L36

This was referenced Jan 29, 2018
@frank-dspeed
Copy link

@justinbmeyer please review and merge if its good looking

@chasenlehara
Copy link
Member

Fixed by #103 and released in 4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants