Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Async Connection via async feathersClient #104

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature: Async Connection via async feathersClient #104

wants to merge 4 commits into from

Commits on Feb 2, 2018

  1. Feature: Async Connection via async feathersClient 

    This changes nothing from the existing API it adds only the option to supply a promise as feathers client i need this feature and think its usefull for any one who does newer coding styles and does things like i do:

frathers-client-async.js

```
/* global window */
import loader from '@loader';

let clientUrl;

if (window && window.fetch) {
  clientUrl = '~/models/feathers/v3/feathers-client.socketio.js';
} else {
  clientUrl = '~/models/feathers/v3/feathers-client.rest.js';
} 

export const feathersClient = loader.import(clientUrl).then((module)=>{ return module.feathersClient; }, err=>{
  new Error('Feathers-client Error '+ clientUrl,err);
}); 


export default feathersClient;
```
    @frank-dspeed
    frank-dspeed committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    4f14d99 View commit details
    Browse the repository at this point in the history

  2. Fixed unneeded whitespaces

    @frank-dspeed
    frank-dspeed committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    d4f9890 View commit details
    Browse the repository at this point in the history

  3. Add Config Example.

    @frank-dspeed
    frank-dspeed committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    ff1fce8 View commit details
    Browse the repository at this point in the history

  4. Added Comment about using a Promise

    @frank-dspeed
    frank-dspeed committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    011fc7c View commit details
    Browse the repository at this point in the history