Cleanup markdown sample code #408
Conversation
can-connect.md
Outdated
| var dataUrl = require("can-connect/data/url/"); | ||
| var constructor = require("can-connect/constructor/"); | ||
| var todosConnection = connect([dataUrl, constructor],{ | ||
| ```javascript |
There was a problem hiding this comment.
Why did this change from just js?
There was a problem hiding this comment.
consistency. no particular reason. there were lots of js and lots of javascript, so I just picked one.
There was a problem hiding this comment.
This is fine, but note that even some of our own tools don’t support javascript.
There was a problem hiding this comment.
I don't really mind either way. They use js now.
can-connect.md
Outdated
| require("can-connect/constructor/constructor"), | ||
| require("can-connect/data/url/url") | ||
| const todoConnection = connect([ | ||
| require("can-connect/constructor/constructor"), |
There was a problem hiding this comment.
I think these should be tabs and not spaces to be consistent with what’s in our style guide.
There was a problem hiding this comment.
While I would normally agree, I thought I had read somewhere that you shouldn't use tabs in markdown code. Am i mistaken?
There was a problem hiding this comment.
If we want to make this change, we need to update all of the .editorconfig files to make sure spaces are used in .md files. But it is still going to be impossible to use the correct spacing in inline docs inside of .js files. For that reason alone, I would say we should not make this change. I haven't seen any problems with using tabs in markdown. Can you provide a link?
There was a problem hiding this comment.
I don't have a link, and searching did not turn one up. I just recall it being mentioned last time the tabs-vs-spaces argument came up. It makes to difference to me though. They use tabs now.
christopherjbaker
changed the title
This pull request was created with Landscaper.
The following code mods were used to create this PR:
Please review this PR carefully as Landscaper does not guarantee any code mod's quality.