get rid of can-util #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-construct-super.js
Outdated
| @@ -46,7 +47,7 @@ var isFunction = canIsFunction, | |||
| Construct._defineProperty = function(addTo, base, name, descriptor) { | |||
| var _super = Object.getOwnPropertyDescriptor(base, name); | |||
| if(_super) { | |||
| canEach(getset, function (method) { | |||
| canReflect.eachKey(getset, function (method) { | |||
There was a problem hiding this comment.
Because getset is an array, I think canReflect.each would be better here.
There was a problem hiding this comment.
Thanks, I had doubts about it, it's fixed!
chasenlehara
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for canjs/canjs#4218