Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove can-util from all CanJS 4.0 and 5.0 packages #4218

Closed
justinbmeyer opened this issue Jun 25, 2018 · 4 comments
Closed

Remove can-util from all CanJS 4.0 and 5.0 packages #4218

justinbmeyer opened this issue Jun 25, 2018 · 4 comments
Assignees

Comments

@justinbmeyer
Copy link
Contributor

justinbmeyer commented Jun 25, 2018

  1. Clone either major or master of canjs/canjs
  2. do an npm i
  3. npm ls can-util

This gives something like this for major:

├─┬ can-compute@4.0.3
│ └── can-util@3.11.5  deduped
├─┬ can-connect@3.0.0-pre.14 !
│ └─┬ can-make-rest@0.1.3
│   └── can-util@3.11.5  deduped
├─┬ can-connect-feathers@5.0.0-pre.3 !
│ └── can-util@3.11.5  deduped
├─┬ can-construct-super@3.1.4 !
│ └── can-util@3.11.5  deduped
├─┬ can-define@2.3.5
│ └─┬ can-simple-observable@2.0.5 !! (just needs dep removed)
│   └── can-util@3.11.5  deduped
├─┬ can-define-validate-validatejs@1.0.1
│ └── can-util@3.11.5  deduped
├─┬ can-fixture-socket@2.0.0-pre.1
│ └── can-util@3.11.5  deduped
├─┬ can-list@4.0.2
│ └── can-util@3.11.5  deduped
├─┬ can-map@4.0.1
│ └── can-util@3.11.5  deduped
├─┬ can-map-define@4.0.0
│ └── can-util@3.11.5  deduped
├─┬ can-reflect-promise@2.0.1
│ └── can-util@3.11.5  deduped
├─┬ can-route@4.1.2  !
│ └── can-util@3.11.5  deduped
├─┬ can-route-pushstate@4.0.5 !
│ └── can-util@3.11.5  deduped
├─┬ can-simple-observable@2.0.4 !
│ └── can-util@3.11.5  deduped
├─┬ can-stache-converters@4.0.2 !
│ └── can-util@3.11.5  deduped
├─┬ can-stream-kefir@1.0.1
│ └── can-util@3.11.5  deduped
├─┬ can-test-helpers@1.1.2 ?
│ └── can-util@3.11.5  deduped
├── can-util@3.11.5 
├─┬ can-validate-legacy@1.2.0
│ └── can-util@3.11.5  deduped
├─┬ can-view-nodelist@4.2.0 !
│ └── can-util@3.11.5  deduped
├─┬ react-view-model@1.0.0 ?
│ └── can-util@3.11.5  deduped
└─┬ steal-stache@4.1.2
  └─┬ can-view-import@4.0.2 !
    └── can-util@3.11.5  deduped

clone the project that is using can-util, see what is being being used from can-util (via search for can-util), and then try to replace it with a different package.

@justinbmeyer
Copy link
Contributor Author

var fragment = require('can-util/dom/fragment/fragment');
var makeArray = require('can-util/js/make-array/make-array');
var frag = require('can-util/dom/frag/frag');
var fragment = require('can-fragment');
var makeArray = require("can-reflect").toArray;
var frag = fragment;

@cherifGsoul
Copy link
Member

cherifGsoul commented Jul 2, 2018

The checked items are fixed and merged:

  • can-compute@4.0.3 (PR sent and in review)
  • can-make-rest@0.1.3
  • can-connect-feathers@5.0.0-pre.3
  • can-construct-super@3.1.4
  • can-define via can-simple-observable
  • can-define-validate-validatejs@1.0.1
  • can-fixture-socket@2.0.0-pre.1
  • can-list@4.0.2
  • can-map@4.0.1
  • can-map-define@4.0.0
  • can-reflect-promise@2.0.1
  • can-route@4.1.2
  • can-route-pushstate@4.0.5
  • can-simple-observable@2.0.4
  • can-stache-converters@4.0.2
  • can-stream-kefir@1.0.1
  • can-test-helpers@1.1.2
  • can-validate-legacy@1.2.0
  • can-view-nodelist@4.2.0
  • react-view-model@1.0.0
  • steal-stache@4.1.2 via can-view-import@4.0.2

@cherifGsoul
Copy link
Member

@justinbmeyer react-view-model is now ylem and dosen't have any dependency to can-util, do we have to fix old versions?

@chasenlehara
Copy link
Member

Has everything been released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants