fixes a bug with properties not being able to be re-assigned

canjs · Jul 6, 2018 · 45628e1 · 45628e1
1 parent eb59245
commit 45628e1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/can-define.js b/can-define.js
@@ -1044,7 +1044,8 @@ define.makeSimpleGetterSetter = function(prop){
 			set: function(newVal){
 				return setter.call(this, define.types.observable(newVal));
 			},
-			enumerable: true
+			enumerable: true,
+            configurable: true
 		};
 	}
 	return simpleGetterSetters[prop];

diff --git a/define-helpers/define-helpers.js b/define-helpers/define-helpers.js
@@ -25,6 +25,7 @@ var defineHelpers = {
 			Object.defineProperty(map, "_instanceDefinitions", {
 				configurable: true,
 				enumerable: false,
+				writable: true,
 				value: {}
 			});
 			instanceDefines = map._instanceDefinitions;
@@ -139,6 +140,7 @@ var defineHelpers = {
 			var oldValue = this._data[prop];
 			if(oldValue !== undefined) {
 				delete this._data[prop];
+				delete this[prop];
 				this.dispatch({
 					type: prop,
 					target: this,

diff --git a/map/map-test.js b/map/map-test.js
@@ -1397,7 +1397,14 @@ QUnit.test("deleteKey works (#351)", function(){
 
 	map.deleteKey("foo");
 
+	var pd = Object.getOwnPropertyDescriptor(map, "foo");
+
+
+	QUnit.ok(!pd, "no property descriptor");
+
 	QUnit.deepEqual( canReflect.getOwnKeys(map), [] );
+
+	map.set("foo", "bar");
 });
 
 QUnit.test("type called with `this` as the map (#349)", function(){