468 remove false warning if only default type #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasenlehara
approved these changes
Jul 12, 2019
phillipskevin
requested changes
Jul 15, 2019
There was a problem hiding this comment.
@mikemitchel can you copy over your test case from can-define-mixin (https://github.com/canjs/can-define-mixin/blob/42865d6c1eab63100693545b0d40981ac61b29c9/test/define-mixin-test.js#L479)? And remove any tests here that are testing the same thing. That one covers more cases and will be easier to add test cases to in the future.
phillipskevin
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a 'false positive' warning for
typebeing ignored with a zero-arg getter. It now allows the defaulttypeset bycan-define/map/mapto exist with a zero-arg getter, and not warn.Closes #468