Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for events and follow the used module pattern #42

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Add docs for events and follow the used module pattern #42

merged 1 commit into from
Dec 4, 2018

Conversation

cherifGsoul
Copy link
Member

This fix #31 :

  • Move node.js to node/node.js

  • Move dom-events.js to events/events.js

  • Document events/events.js

justinbmeyer
justinbmeyer requested changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@justinbmeyer justinbmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For backwards compatibility, You’ll need to leave some legacy modules in place that re-export. Example: node.js should export node/node.js

@cherifGsoul cherifGsoul self-assigned this Dec 3, 2018
@cherifGsoul cherifGsoul merged commit 8c1b07e into master Dec 4, 2018
@cherifGsoul cherifGsoul deleted the 31-document-events branch December 4, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinbmeyer justinbmeyer justinbmeyer approved these changes

Assignees

@cherifGsoul cherifGsoul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docs for dom-events.js
2 participants
@cherifGsoul @justinbmeyer