Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure ids are going to be unique #102

Closed
justinbmeyer opened this issue Feb 24, 2017 · 0 comments
Closed

Make sure ids are going to be unique #102

justinbmeyer opened this issue Feb 24, 2017 · 0 comments
Labels
bug p2

Comments

@justinbmeyer
Copy link
Contributor

If you create a folder in the following jsbin ( http://jsbin.com/vasixip/edit?html,js,output ), the root folder name is always changed because there are conflicts with ids.

currentId should start at least higher than the number of records:

can-fixture/helpers/legacyStore.js

Line 11 in 7cf8a73

var currentId = 0,

andrejewski added a commit that referenced this issue Apr 24, 2017
@andrejewski
Make IDs always unique; fixes #102
8b65f35
@andrejewski andrejewski mentioned this issue Apr 24, 2017
Merged
andrejewski added a commit that referenced this issue Apr 24, 2017
@andrejewski
Merge pull request #108 from canjs/ensure-unique
a502c7c 
Make IDs always unique; fixes #102
andrejewski added a commit that referenced this issue Apr 25, 2017
@andrejewski
Make IDs unique based on existing items; fixes #102
0c5d0d4
andrejewski added a commit that referenced this issue May 24, 2017
@andrejewski
Merge pull request #110 from canjs/102-id-unique
12d8d39 
Make IDs unique based on existing items; fixes #102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justinbmeyer