Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IDs always unique; fixes #102 #108

Merged
merged 1 commit into from
Apr 24, 2017
Merged

Make IDs always unique; fixes #102 #108

merged 1 commit into from
Apr 24, 2017

Conversation

andrejewski
Copy link
Contributor

The getUniqueId() cannot be influenced by anything other than its execution and replaces currentId to ensure uniqueness.

@matthewp
Copy link
Contributor

Is there an associated issue this fixes?

@andrejewski
Copy link
Contributor Author

Haha #102, the one in the commit/PR title

@matthewp
Copy link
Contributor

Is it possible to write up a test that replicates the problem described in #102 ?

@andrejewski
Copy link
Contributor Author

Painfully yes; but I don't think it is worth the time.

@matthewp
Copy link
Contributor

Tests are always worth the pain 🤠 . To properly test DoneJS I wrote several new projects (and this one and this one and this one).

Personally I think this change is complex enough to warrant a test. A test would also ensure that the edge-case doesn't come up again.

@andrejewski andrejewski merged commit a502c7c into master Apr 24, 2017
@andrejewski andrejewski deleted the ensure-unique branch April 24, 2017 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrejewski @matthewp