Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dev code for webpack compatibility #149

Merged
merged 3 commits into from
Jun 27, 2018
Merged

Conversation

cherifGsoul
Copy link
Member

This fixes the first part of this issue canjs/canjs#4170 to remove debug code from the production builds.

.editorconfig Outdated
@@ -2,4 +2,4 @@
[*]
end_of_line = LF
indent_style = tab
indent_size = 4
indent_size = 2
Copy link
Contributor

@justinbmeyer justinbmeyer Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use tabs for indentation except in package.json and other similar configs.

Copy link
Member Author

@cherifGsoul cherifGsoul Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I changed the indent_size only! 2 is not what it is used?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 is what is used.

Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change indent_size to 4.

@cherifGsoul cherifGsoul merged commit 45c650c into master Jun 27, 2018
@cherifGsoul cherifGsoul deleted the fix-webpack-debug-style branch June 27, 2018 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants