Fix #3182 (can.List.map doesn't properly handle context arg) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the passed context and fixed the code for List.
dtomack
added a commit
to dtomack/canjs
that referenced
this pull request
May 2, 2017
dtomack
added a commit
to dtomack/canjs
that referenced
this pull request
May 2, 2017
…n-list#38 with the addition of modifying the map/list code properly pass the client's context if it is provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses canjs/canjs#3182. Fixes the issue in both
map()and thefilter()functions of using a bitwise instead of logical or as a short-circuit to determine the context to be passed to the client callback function.