Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Issue #3182. #3190

Conversation

dtomack
Copy link

@dtomack dtomack commented May 2, 2017

Addresses #3182. Fixes the issue in both map() and the filter() functions of using a bitwise instead of logical or as a short-circuit to determine the context to be passed to the client callback function.

These are the same changes in canjs/can-list#38 modified to apply to 2.3-legacy.

@chasenlehara chasenlehara requested a review from phillipskevin May 2, 2017 16:46
…n-list#38 with the addition of modifying the map/list code properly pass the client's context if it is provided.
@dtomack dtomack force-pushed the Address_Issue_3182_in_2.3-Legacy_branch branch from bf9be4b to 7c46791 Compare May 2, 2017 18:51
@chasenlehara chasenlehara merged commit 2a04857 into canjs:2.3-legacy May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants