get rid of can-util #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasenlehara
reviewed
Jul 2, 2018
can-list.js
Outdated
| var canReflect = require('can-reflect'); | ||
| var isPromise = canReflect.isPromise; | ||
| var makeArray = canReflect.toArray; |
There was a problem hiding this comment.
It’s uncommon for us to write it like that; I would just use canReflect where it’s needed.
chasenlehara
reviewed
Jul 3, 2018
can-list.js
Outdated
| this.replace(instances); | ||
| } else { | ||
| teardownMapping = instances.length && mapHelpers.addToMap(instances, this); | ||
| this.push.apply(this, makeArray(instances || [])); | ||
| this.push.apply(this, canReflect.toArray(instances || [])); |
There was a problem hiding this comment.
It’d be nice if we changed this to check for instances, something like:
instances === undefined ? [] : canReflect.toArray(instances)
chasenlehara
reviewed
Jul 3, 2018
can-list.js
Outdated
| @@ -737,7 +734,7 @@ assign(List.prototype, { | |||
| } | |||
| }); | |||
| } else { | |||
| this.splice.apply(this, [0, this.length].concat(makeArray(newList || []))); | |||
| this.splice.apply(this, [0, this.length].concat(canReflect.toArray(newList || []))); | |||
There was a problem hiding this comment.
Same with this line; we shouldn’t pass an empty array to canReflect.toArray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for canjs/canjs#4218