New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get rid of can-util #102
get rid of can-util #102
Conversation
bubble.js
Outdated
var canReflect = require('can-reflect'); | ||
var isEmptyObject = require('can-util/js/is-empty-object/is-empty-object'); | ||
var makeArray = canReflect.toArray; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just use canReflect.toArray where you need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
bubble.js
Outdated
var makeArray = canReflect.toArray; | ||
var isEmptyObject = function(value) { | ||
return canReflect.size(value) === 0; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only used once in the file, I would put the check inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
//var isFunction = require("can-util/js/is-function/is-function"); | ||
var assign = require("can-util/js/assign/assign"); | ||
var assign = require("can-assign"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worries me a little bit that the tests are passing but this module isn’t in package.json
Same thing with can-log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed!
for canjs/canjs#4218